test(stryker): Replace line numbers by error index

[karfau]

so the snapshots match even when stryker mutates the files.

The intermediate mapping is also stored to tests/error/reported.json for easier inspection, so I .gitignored it.

The good news: The score improved quite a bit 🎉

Fixes #200

[brody4hire]

Thanks for your timely work on this.

My one, minor question is that it looks like this is using a possibly hackish utility function, with "sax.js" hardcoded multiple times. And I am not sure if I understand it 100%. I am thinking it may be ideal if we can find a better way to improve the reusability.

[karfau]

I think I should be able to do another round of self review and try to refactor/document some more things to make them more generic & easy to understand.
But I'm not sure how fast I'll be able to do that.

Of course the whole test suite about the reported errors and warnings is not trivial to understand.

[brody4hire]

Of course the whole test suite about the reported errors and warnings is not trivial to understand.

I think that is the key, and to be extra clear I think this is the result of the original design.

Further refactoring and improvement would be awesome, assuming you have the time for it. Otherwise I would not object to improving it someday later. Thanks again for all of your care and efforts on such a messy code base!

[karfau]

@brodybits I'm not sure what to understand from your reply.
Do you think we can land it as is to solve the stryker issue and improve it later, or do do you prefer we invest more time into this before we land it?
(From my perspective, we should land it so we can take the next steps towards 0.6.0 .)

[brody4hire]

It is fine with me if you want to land these changes now.

While I think it would be nice to land these changes in a better state, it would probably be better to fix the build now.

Thanks again.

[karfau]

@brodybits I think I did everything I could, to improve it in this short period of time.

Please have a look, if this is the direction you were talking about.
You can land the PR or I will do it in some days, if you don't give me a different signal.

[brody4hire]

From a quick read it looks better to me, no more objections on my part. I would like to leave this up to @karfau to merge.

I am also very happy to see the improvement in the mutation score.