Release v2.1.1 #885
Merged
Release v2.1.1 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
added
the
webpa-common archival/deprecation
Codecov Report
@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 82.23% 82.22% -0.02%
==========================================
Files 138 138
Lines 8556 8556
==========================================
- Hits 7036 7035 -1
Misses 1328 1328
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Kudos, SonarCloud Quality Gate passed!
|
johnabass
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included:
#655
** this won't deprecate webpa-common fully from scytale - but will remove the logging and go-kit features from scytale
added zap logger to servicecfg.NewEnvironment to be used in Scytale
added adapter struct to act as an interface so zap logger could be used in certain functions that required the Log interface