-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update middleware function to correctly honor trace headers #115
Conversation
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 77.20% 71.55% -5.66%
==========================================
Files 4 4
Lines 215 232 +17
==========================================
Hits 166 166
- Misses 44 61 +17
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some questions, but overall lgtm 🍻
wrpcontext
package. Candlelight then propagates the trace context with this info so that remote spans can be honored and not broken.