feat: remove arrange #221
Merged
feat: remove arrange #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
commented
Nov 1, 2023
denopink
force-pushed
the
denopink/feat/remove-arrange-and-addgoschtalt
branch
from
6fd3a42
to
7ef3c1b
Compare
johnabass
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
This looks fine, but we should do another issue/PR to remove goschalt completely. bascule should really just take a dependency on a bascule.Config object, and unfold itself accordingly. The application would be responsible for obtaining a bascule.Config in whatever way it likes, whether goschtalt or some other means.
denopink
commented
Nov 2, 2023
Comment on lines
-105
to
-127
| "everything included": basicAuth + bearerAuth + ` | ||
| capabilities: | ||
| type: "enforce" | ||
| prefix: "test" | ||
| acceptAllMethod: "all" | ||
| endpointBuckets: | ||
| - "aaaa\\b" | ||
| - "bbbn/.*\\b" | ||
| `, | ||
| "capabilities monitoring": basicAuth + bearerAuth + ` | ||
| capabilities: | ||
| type: "monitor" | ||
| prefix: "test" | ||
| acceptAllMethod: "all" | ||
| endpointBuckets: | ||
| - "aaaa\\b" | ||
| - "bbbn/.*\\b" | ||
| `, | ||
| "no capability check": basicAuth + bearerAuth, | ||
| "basic only": basicAuth, | ||
| "bearer only": bearerAuth, | ||
| "empty config": ``, | ||
| } |
There was a problem hiding this comment.
@johnabass do we still want to support all these use cases?
denopink
force-pushed
the
denopink/feat/remove-arrange-and-addgoschtalt
branch
from
89bba11
to
c7f9151
Compare
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 85.68% 85.56% -0.13%
==========================================
Files 36 36
Lines 1488 1482 -6
==========================================
- Hits 1275 1268 -7
- Misses 195 196 +1
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove arrange