Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: add missing log field satClientID #206

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 9, 2023

No description provided.

@denopink denopink added the bug Something isn't working label Aug 9, 2023
@denopink denopink self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #206 (fc53c6c) into main (1941776) will increase coverage by 0.17%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   85.51%   85.68%   +0.17%     
==========================================
  Files          36       36              
  Lines        1491     1488       -3     
==========================================
  Hits         1275     1275              
+ Misses        198      195       -3     
  Partials       18       18              
Flag Coverage Δ
unittests 85.68% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
basculehttp/log.go 41.09% <0.00%> (+1.62%) ⬆️

@denopink denopink merged commit 4df592c into main Aug 9, 2023
15 of 17 checks passed
@denopink denopink deleted the denopink/patch/add-missing-satID-log-fields branch August 9, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant