Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text sticking after list #104

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix text sticking after list #104

merged 1 commit into from
Oct 29, 2024

Conversation

Kevinrob
Copy link
Contributor

@Kevinrob Kevinrob commented Nov 3, 2023

I have an issue when parsing text after a list.

<ul>
  <li>item followed with a text</li>
</ul>
text after the list

This HTML is parsed as:

- item followed with a text
 text after the list

But this markdown will collapse text after the list with item followed with a text.
We can check here the result.

With this changes, the new output is:

- item followed with a text

text after the list

And now, we don't have the text outside the list collapsed with the last list item.
We can check here again.

PS: I fixed a other test about UTF-8, I think that nokogiri changes the way it break with encoding.
PS2: I switched byebug by ruby/debug

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@Kevinrob
Copy link
Contributor Author

Kevinrob commented Nov 3, 2023

@xijo What do you think of this PR?

@Kevinrob
Copy link
Contributor Author

I close this PR as with don't get any feedback about it in 1 year.

@Kevinrob Kevinrob closed this Oct 28, 2024
@xijo
Copy link
Owner

xijo commented Oct 29, 2024

I'm so sorry @Kevinrob. I've been hording these in my inbox for ages now and always procrastinated. Let's get this done, this is a good PR. Thank you very much for taking the time and beeing more than patient!

@xijo xijo reopened this Oct 29, 2024
@xijo xijo merged commit 6a71bc0 into xijo:master Oct 29, 2024
@xijo
Copy link
Owner

xijo commented Oct 29, 2024

Merged. I'll also bump ruby versions, move the CI and release a new version. Thanks for your contribution!

@Kevinrob
Copy link
Contributor Author

Merged. I'll also bump ruby versions, move the CI and release a new version. Thanks for your contribution!

Ho nice! Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants