This repository was archived by the owner on Dec 10, 2024. It is now read-only.
Resolves #1405: only one endpoint was missing #1927
Merged
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
suggested changes
May 4, 2024
external_status_checks.go
Outdated
| // | ||
| // Gitlab API docs: | ||
| // https://docs.gitlab.com/ee/api/status_checks.html#retry-failed-status-check-for-a-merge-request | ||
| func (s *ExternalStatusChecksService) RetryFailedStatusCheckForAMergeRequest(pid interface{}, mergeRequest int, opt *RetryFailedStatusCheckForAMergeRequestOptions, options ...RequestOptionFunc) (*Response, error) { |
There was a problem hiding this comment.
All the params that are part of the URL are passed as function parameters. The option structs are only used for sending options to the API which in this case is not applicable as all params are art of the URL and not request body is expected.
svanharmelen
approved these changes
May 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the endpoints to the documentation here: https://docs.gitlab.com/ee/api/status_checks.html there is only one endpoint not currently supported. This is https://docs.gitlab.com/ee/api/status_checks.html#retry-failed-status-check-for-a-merge-request
I've added a new function for this endpoint and a very basic test.