Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GET response for jenkins and drone integrations #1887

Merged

Conversation

jmajaca
Copy link

@jmajaca jmajaca commented Feb 28, 2024

I recently created #1886 and #1885 PRs.

But I missed that GET response also changed for those integrations, so I updated them now:

  • removed Token from DroneCIServiceProperties
  • added EnableSSLVerification to JenkinsCIServiceProperties
  • updated GitLab API links for those two integrations

Also, I saw that other integrations/services are not in sync with current GitLab API and I would like to update them. Do you prefer me opening PR for each integration/service individually or grouping them in few PRs?

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmajaca 👍🏻

@svanharmelen svanharmelen merged commit c46c5fa into xanzy:main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants