This repository was archived by the owner on Dec 10, 2024. It is now read-only.
fix: application settings marshalling #1825
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-mt
force-pushed
the
fix/application-settings
branch
from
75f1af5 to
3b2e060
Compare
steve-mt
changed the title
steve-mt
commented
Oct 20, 2023
What --- Update `Settings.PerformanceBarAllowedGroupID` to be an `int` instead `string` Why --- The API returns an int because it's a group ID: ``` curl -s --header "PRIVATE-TOKEN: TOKEN" "https://gitlab.example.com/api/v4/application/settings" | jq -r '.performance_bar_allowed_group_id' 1234 ``` The [documentation](https://gitlab.com/gitlab-org/gitlab/-/blob/784401ac8b5bf5ae3056cc84a95fb2be37c83934/doc/api/settings.md#L92) specifies that it's an `int`, and it's also stored as an int in the [database](https://gitlab.com/gitlab-org/gitlab/-/blob/784401ac8b5bf5ae3056cc84a95fb2be37c83934/db/structure.sql#L11472). Signed-off-by: Steve Xuereb <sxuereb@gitlab.com>
steve-mt
force-pushed
the
fix/application-settings
branch
from
3b2e060 to
ddc846c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
Settings.PerformanceBarAllowedGroupIDto be anintinsteadstringWhy
The API returns an int because it's a group ID:
The documentation specifies that it's an
int, and it's also stored as an int in the database.