This repository was archived by the owner on Dec 10, 2024. It is now read-only.
Align project notification events #1809
Merged
+188
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicePatrick
changed the title
RicePatrick
changed the title
|
@svanharmelen - This should be ready for review when you have a moment. Just adds a couple of events to the existing APIs (matched the current alphabetical order style), and added a couple tests for Update and Get. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for several notification events that are present on the group/project level per the API documentation here: https://docs.gitlab.com/ee/api/notification_settings.html#update-groupproject-level-notification-settings
I also added a test for the project API testing that nested events returned properly.