Make the default date segments configurable #493
Merged
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This change should make it easier for people to add custom date validation by giving them control of the identifiers used by Rails' multiparameter fields. In the linked PR the i (which tells Rails to cast to an Integer) is removed. ministryofjustice/laa-submit-crime-forms#681 Refs #489
peteryates
force-pushed
the
make-date-segments-configurable
branch
from
894784a to
7a7c882
Compare
peteryates
added a commit
that referenced
this pull request
Apr 15, 2024
Following on from #493 this allows the date segments to be overridden on a field-by-field basis instead of just at the app level.
peteryates
added a commit
that referenced
this pull request
Apr 23, 2024
Following on from #493 this allows the date segments to be overridden on a field-by-field basis instead of just at the app level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should make it easier for people to add custom date validation by giving them control of the identifiers used by Rails' multiparameter fields.
This was suggested in #489 and in [the linked PR] the
i(which tells Rails to cast to an Integer) is removed, allowing the custom validation to take place before Rails tries casting the values to aDate.