Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): set type to "module" for Svelte template #977

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Sep 12, 2024

When adding shadcn-svelte, I discovered that the template project's type was not set to "module," causing errors when using "export default" in postcss.js. Since ESM is now widely popular, shouldn't setting "type: module" by default be fine?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 42c3eeb
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66e2b0002565ad0008212d6d
😎 Deploy Preview https://deploy-preview-977--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template was based on Vite's svelte template, and looks like they also update it to use ESM. So let's do it!

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@977

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@977

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@977

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@977

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@977

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@977

wxt

pnpm add https://pkg.pr.new/wxt@977

commit: 42c3eeb

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (78f91fe) to head (42c3eeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   81.93%   81.70%   -0.23%     
==========================================
  Files         125      125              
  Lines        6604     6604              
  Branches     1101     1099       -2     
==========================================
- Hits         5411     5396      -15     
- Misses       1179     1194      +15     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit e760ee4 into wxt-dev:main Sep 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants