Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fields for week, month and color #725

Closed
PanderMusubi opened this issue Dec 31, 2021 · 5 comments · Fixed by #765
Closed

Support fields for week, month and color #725

PanderMusubi opened this issue Dec 31, 2021 · 5 comments · Fixed by #765
Labels
enhancement New feature, or existing feature improvement

Comments

@PanderMusubi
Copy link
Contributor

Please, support fields for week, month and color. See the example at https://getbootstrap.com/docs/5.1/content/reboot/?optionsRadios=option1#forms

    <p>
      <label for="week">Example week</label>
      <input type="week" id="week">
    </p>
    <p>
      <label for="month">Example month</label>
      <input type="month" id="month">
    </p>
    <p>
      <label for="color">Example color</label>
      <input type="color" id="color">
    </p>
@azmeuk
Copy link
Member

azmeuk commented Jan 2, 2022

Hi. Thank you for your contribution. The MonthField already exists, even if it was not documented, though it is fixed now.

For the record:

@azmeuk azmeuk added the enhancement New feature, or existing feature improvement label Jan 2, 2022
@PanderMusubi
Copy link
Contributor Author

Is a PR welcomed for week and color?

@PanderMusubi
Copy link
Contributor Author

Thanks for merging the related PR and other PRs. Since the last release is one year ago, could you please make a new release so PyPI will include these these contributions?

@azmeuk
Copy link
Member

azmeuk commented Jan 13, 2023

@PanderMusubi are you interested in reviewing #765?

@PanderMusubi
Copy link
Contributor Author

Looks good. Perhaps refactor

import datetime

to

 from datetime.datetime import strptime

@greyli can you have look too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, or existing feature improvement
Development

Successfully merging a pull request may close this issue.

2 participants