Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Sphinx 7 #114

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Test Sphinx 7 #114

merged 1 commit into from
Dec 14, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 23, 2023

Sphinx 7.0.0 was released on 2023-04-30 and we're now up to 7.2.6.

Let's test it.

However, combined with PR #113, that means we have 6 Python versions x 5 Sphinx versions x 3 operating systems = 90 jobs in the matrix!

I suggest we drop support for Sphinx 4 to bring it down to 6x4x3 = 72 jobs.

Alternatively, we could run the full matrix for Ubuntu, but selectively run a subset of versions for other operating systems. For example, for macOS and Windows, only test the lowest/highest supported Sphinx (4 and 7), and/or Python (3.8 and 3.12).

@Daltz333
Copy link
Member

I'm of the opinion we test

  • Last 3 sphinx versions
  • Last 4 Python versions

@hugovk
Copy link
Contributor Author

hugovk commented Nov 23, 2023

I recommend that what we test == what we support. So support Sphinx 5-7, and Python 3.9-3.12, dropping Sphinx 4 and Python 3.8?

@TheTripleV
Copy link
Member

I think it's ok to keep everything in. The only issue would be too many macos runners delaying allwpilib builds but this repo doesn't get daily activity so i don't think it's a big deal.

@Daltz333
Copy link
Member

Well, it's also possible support. I agree we shouldn't support what we don't use. And since really this project was made for frc-docs, we should closely align to the update timelines we do there (major dependency/python updates once a year).

I think I agree with @hugovk and it doesn't really hurt us. Users on older Sphinx versions can pin to a lower opengraph version. It's not like we're booming with momentum.

@Daltz333 Daltz333 merged commit fa24601 into wpilibsuite:main Dec 14, 2023
65 checks passed
@hugovk hugovk deleted the add-sphinx-7 branch December 14, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants