Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning if WpOrgApi::get_plugin_checksums() fails #105

Merged
merged 1 commit into from May 17, 2023
Merged

Log warning if WpOrgApi::get_plugin_checksums() fails #105

merged 1 commit into from May 17, 2023

Conversation

semseysandor
Copy link
Contributor

WpOrgApi::get_plugin_checksums() throws exception if failed to fetch checksums (e.g. network issues, wrong URL). In these cases at least a warning should be logged to add a hint about the error and save 90% of debug time.

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@danielbachhuber danielbachhuber merged commit ac6b835 into wp-cli:main May 17, 2023
30 checks passed
@semseysandor semseysandor deleted the warning-get-plugin-checksum branch May 17, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants