Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce prototype_build_details_comment refactoring for FAD #639

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Mar 11, 2025

This is in the context of App Center being shut down and us migrating to Firebase App Distribution as a replacement

Note

This PR is simply a cherry-pick to restore #630 (which had been reverted in #633 in order to allow us to do a minor release without breaking changes first before we include this breaking change in a next major release).

As such, this PR has already been reviewed in the context of #630. Refer to #630 for details.

Internal References

  • 175-gh-Automattic/apps-infra-plans
  • 25739-gh-bloom/DayOne-Apple
  • pdnsEh-1zD-p2

This is in the context of App Center being shut down and us migrating to Firebase App Distribution as a replacement
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 11, 2025

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@AliSoftware AliSoftware requested review from twstokes, iangmaia and a team March 11, 2025 15:17
@AliSoftware AliSoftware self-assigned this Mar 11, 2025
@AliSoftware AliSoftware changed the title Refactor prototype_build_details_comment for FAD Re-introduce prototype_build_details_comment refactoring for FAD Mar 11, 2025
Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's back 😎

:shipit: 🚀

@AliSoftware AliSoftware merged commit ae15983 into trunk Mar 11, 2025
8 of 9 checks passed
@AliSoftware AliSoftware deleted the restore-prototype_builds_details_comment branch March 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants