Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump axios #2814

Closed
6543 opened this issue Nov 12, 2023 · 7 comments
Closed

bump axios #2814

6543 opened this issue Nov 12, 2023 · 7 comments
Labels
dependencies documentation docu & docs security
Milestone
2.0.0

Comments

@6543
Copy link
Member

6543 commented Nov 12, 2023 •
edited

ref #2799 (comment)

blocked by jeffbski/wait-on#143 (jeffbski/wait-on#147)
@qwerty287 qwerty287 added the documentation docu & docs label Nov 13, 2023
@xoxys
Copy link
Member

xoxys commented Nov 13, 2023

Use overrides in the meantime? https://github.com/woodpecker-ci/woodpecker/blob/main/web/package.json#L72-L74

@qwerty287
Copy link
Contributor

This won't work as wait-on must be updated, see jeffbski/wait-on#147

@xoxys
Copy link
Member

xoxys commented Nov 13, 2023

No overrides are working for peer/transitive dependencies.

@qwerty287
Copy link
Contributor

Yes, but I mean changes in code. Axios had a breaking change at some point and force-updating it would break wait-on. You can take a look at the linked PR changes.

@xoxys
Copy link
Member

xoxys commented Nov 13, 2023

Ah ok missed that -.-

@qwerty287
Copy link
Contributor

https://github.com/jeffbski/wait-on/releases/tag/v7.2.0 fixed it

@pat-s pat-s closed this as completed Nov 15, 2023
@pat-s pat-s reopened this Nov 15, 2023
@6543 6543 added this to the 2.0.0 milestone Nov 15, 2023
@pat-s
Copy link
Contributor

pat-s commented Nov 19, 2023

will be fixed by #2840

@pat-s pat-s closed this as completed Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies documentation docu & docs security
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@xoxys @pat-s @6543 @qwerty287