Add validation for since tag version #30
Merged
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation for the [at]since version to make sure they have supplied a valid version for that tag.
Closes #28
Prereq:
Make sure you have this PR pulled down and that your global PHPCS is referencing this change.
Testing:
https://github.com/woocommerce/woocommerce
.plugins/woocommerce/woocommerce.php
. Add ado_action
orapply_filters
hook with docblock. Add the[at]since
tag without version. For example:phpcs -s plugins/woocommerce/woocommerce.php
.[at]since
tag.Note:
I did not add the check for description as per the original #28 issue as this is already being picked up by the generic PEAR rules.
Task:
After approved and merged, we need to do a release and bump the woocommerce-sniffs version in WooCommerce-monorepo.