-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customTextRenderer not working correctly in v6 #1151
Comments
"not working" is a bit of an overstatement, but yes, the example provided wasn't very good and lacked a null check which was not necessary in React before. Fixed that. :) |
I agree and I'd like to apologize for the way I expressed myself!
Thank you for your quick response and also thank you for maintaining this awesome package ❤️ Unfortunately, I still think that the If the custom text renderer is activated, there are a lot of these elements with the value
If the the custom text renderer is disabled, no such elements will show up:
You will also notice that without the custom text renderer, the text is perfectly selectable (whole line):
Whereas with the custom text renderer, it is not (this used to work pre-v6):
|
Yup, that is a valid bug - thank you for noticing this! |
Before you start - checklist
Description
The
customTextRenderer
doesn't seem to work correctly anymore in v6.If a
customTextRenderer
is defined (even with the example provided under Page -> Props) the text elements are wrongly positioned and there are a lot elements with the contentundefined
:If the
customTextRenderer
is removed, everything works as expected and the text elements are correctly positioned.Steps to reproduce
Expected behavior
Text elements via custom rendered should be positioned correctly and not include
undefined
valuesActual behavior
Text elements are wrongly positioned (clearly visible when using
<mark>
) and containsundefined
valuesAdditional information
No response
Environment
The text was updated successfully, but these errors were encountered: