Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to lack of v141 VC toolset on GitHub Actions runner images #8211

Open
1 task
barnson opened this issue May 16, 2024 · 0 comments · May be fixed by wixtoolset/wix#527 or wixtoolset/wix#528
Open
1 task

Adapt to lack of v141 VC toolset on GitHub Actions runner images #8211

barnson opened this issue May 16, 2024 · 0 comments · May be fixed by wixtoolset/wix#527 or wixtoolset/wix#528
Labels

Comments

@barnson
Copy link
Member

barnson commented May 16, 2024

WiX Version

@Head

.NET or MSBuild or Visual Studio Version

n/a

HeatWave Version

n/a

Windows Version

n/a

Repro Repo

https://github.com/wixtoolset/wix/

Repro Steps

  1. Submit a PR to build using GitHub Actions.
  2. Wait for failure.

Actual Result

Build fails:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\
v170\Microsoft.CppBuild.targets(456,5): error MSB8020: The build tools for 
Visual Studio 2017 (Platform Toolset = 'v141') cannot be found. To build using 
the v141 build tools, please install Visual Studio 2017 build tools.  
Alternatively, you may upgrade to the current Visual Studio tools by selecting 
the Project menu or right-click the solution, and then selecting "Retarget 
solution". [D:\a\wix\wix\src\libs\wcautil\WixToolset.WcaUtil\wcautil.vcxproj]

Per actions/runner-images#9701, the decision to avoid a bug in VS installer was to take a sledgehammer and remove the components related to the problem.

We could:

  1. Install the components at build time.
  2. Drop our current use of older toolsets.

Whatever solution we choose, we need to be prepared to adapt for v4 and v5 bug-fix builds.

Expected Result

Shiny, happy build.

Acknowledgements

  • I acknowledge that this is a fully completed bug report. It is not a question or attempt to get help debugging my issue (because those should be sent to Discussions).
@barnson barnson added the triage label May 16, 2024
barnson added a commit to wixtoolset/wix that referenced this issue Jun 10, 2024
v143 output is compatible back to VS2017 (at least).

Fixes wixtoolset/issues#8211.
barnson added a commit to wixtoolset/wix that referenced this issue Jun 10, 2024
v143 output is compatible back to VS2017 (at least).

Fixes wixtoolset/issues#8211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant