perf(ios): optimize performance by removing excessive logging (DetoxSync). #4718
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
changed the title
asafkorem
force-pushed
the
fix/optimization-logs
branch
2 times, most recently
from
74486fe to
e62b193
Compare
asafkorem
changed the title
asafkorem
force-pushed
the
fix/optimization-logs
branch
from
e62b193 to
81953a5
Compare
asafkorem
force-pushed
the
fix/optimization-logs
branch
from
81953a5 to
783322d
Compare
asafkorem
force-pushed
the
fix/optimization-logs
branch
from
783322d to
5cb9330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excessive logging from DetoxSync affected the performance significantly (the difference could be observed during our stress tests). I removed the logs from DetoxSync and updated its version.