fix(ios): JS animation sync resource issues with RN old & new archs. #4717
+121
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
force-pushed
the
animation-test
branch
2 times, most recently
from
b7b9bb8 to
9eba722
Compare
asafkorem
changed the title
1 task
1 task
asafkorem
force-pushed
the
animation-test
branch
2 times, most recently
from
dbf7e3c to
3de9e93
Compare
asafkorem
force-pushed
the
animation-test
branch
from
3de9e93 to
01a5eea
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new synchronization approach to handle JS delays in
Animated.timingon iOS and new-arch tests.(See the enabled test in the PR changes). Fixes: RN new-arch (iOS): JS animations (
Animated) are not sync'd with Detox #4706Fixes a flaky test involving long network requests, originally merged from feat(ios, new-arch): support new sync resource (node animation updates). #4716.
(See the enabled test in the PR changes.)
Implements branching of the synchronization resource for new-arch vs. old-arch, addressing architectural differences in the synchronization logic. Fixes: The app is busy with the following tasks #4710
See: wix-incubator/DetoxSync#83, wix-incubator/DetoxSync#84, wix-incubator/DetoxSync#85