feat(iOS): support bridgeless mode. #4681

asafkorem · 2025-01-08T13:08:12Z

No description provided.

Fabric flattens the view hierarchy if the elements are not accessible.

Callstack's slider view has a property called 'slider' in new arch (RCTViewComponentView), which is the actual slider. See - https://github.com/callstack/react-native-slider/blob/main/package/ios/RNCSliderComponentView.mm#L26

JSI timers are not being synced on new arch (iOS) since we cannot swizzle them.

detox/test/e2e/09.stress-timeouts.test.js

detox/test/e2e/12.animations.test.js

detox/test/e2e/17.datePicker.test.js

d4vidi · 2025-02-17T14:16:34Z

detox/test/e2e/20.background-foreground.transitions.test.js

@@ -2,9 +2,9 @@ describe(":ios: Background-Foreground Transitions", () => {
 	it("Backgrounding and foregrounding an app should wait for transition to finish", async () => {
 		await device.launchApp({newInstance: true});
 		await device.sendToHome();
-		await expect(element(by.text("Background"))).toBeVisible();
+		await expect(element(by.text("Background"))).toExist();


@asafkorem why?

It's a new native component (replaced the previous one), and when the app is on background this element is really not expected to be visible (only to exist).
Note that only the Active message should be visible because the app is visible. i.e.

await expect(element(by.text("Active"))).toBeVisible();

It's a bug that the previous message was considered as "visible" while the app was in the background. It's because that "AnnoyingWindow" we used to have - no longer exists.

d4vidi · 2025-02-17T14:19:46Z

detox/test/e2e/19.crash-handling.test.js

@@ -51,8 +53,10 @@ describe('Crash Handling', () => {

    if (device.getPlatform() === 'android') {
      jestExpect(error.stack).toContain('\tat java.lang.Thread.run');
-    } else {
+    } else if (!isRNNewArch) {


@asafkorem I think we need to revisit and decide:

The test is @legacy so I think iSRNNewArch is always false (?)

Should we backlog a tech debt?

True, we can remove the isRNNewArch. Detox sometimes consider the app as launched before the error is thrown, so we'll have an error on the next action

It's a technical debt or at least a discussion - whether it's a bug or feature. It's a non-deterministic behaviour because sometimes detox catches the error on-launch and sometimes it will be thrown in the next action (post-launch).

d4vidi · 2025-02-17T14:28:23Z

detox/test/e2e/17.picker.test.js

@@ -1,4 +1,4 @@
-describe.skipIfNewArchOnIOS(":ios: Picker", () => {
+describe(":ios: Picker", () => {


d4vidi · 2025-02-17T14:30:28Z

detox/test/e2e/12.animations.test.js

@@ -9,7 +9,7 @@ describe('React-Native Animations', () => {
      let loopSwitch = element(by.id('UniqueId_AnimationsScreen_enableLoop'));
      await loopSwitch.tap();
      if (device.getPlatform() === 'ios') {
-        await expect(loopSwitch).toHaveValue('1');
+        await expect(loopSwitch).toHaveToggleValue('1');


I think we should add a warning whenever .toHaveValue() is used over a UISwitch. WDYT?

Maybe, not sure, we can talk about that. AFAIK we never did it with other components (CMIIW)
It's a specific component behaviour that was changed over RN versions.. 🤷🏼‍♂️
It was really the accessibility value of the original component before

d4vidi · 2025-02-17T14:37:07Z

detox/test/e2e/14.network.test.js

@@ -22,7 +22,8 @@ describe('Network Synchronization', () => {
    await driver.shortRequest.expectReplied();
  });

-  it('Sync with long network requests - 3000ms', async () => {
+  // todo(new-arch): test is failing
+  it('@legacy Sync with long network requests - 3000ms', async () => {


@asafkorem this looks serious, what's the gap here?

asafkorem force-pushed the feat/bridgeless-mode branch 2 times, most recently from dc250b6 to 0197120 Compare January 13, 2025 16:22

asafkorem added 28 commits January 15, 2025 11:57

test(iOS): enable bridgeless mode on test app.

667f7a2

test(ios): fix swift bridge.

0b37365

demo(iOS): support bridgeless mode with new-arch.

b06b68c

ci: ensure RN .73 without new arch works.

2e4d9d7

ci: update pipeline step title.

ae22233

test(fix,ios): support background search.

Loading
Loading status checks…

03a8397

test(ios): extend timer of visible message if needed.

e75c276

fix(iOS): ignore RCTAccessibilityElement from view hierarchy.

304afe0

test(ios): update type variants based on new-arch.

d13085e

test(iOS): make elements accessible for descendant/ancestor matchers.

924437c

Fabric flattens the view hierarchy if the elements are not accessible.

test(iOS): update view-hierarchy artifact for new arch view.

8881334

feat(ios): support RCTEnhancedScrollView for scrolling.

6f325bf

fix(iOS): replace invalid return value.

a60faac

chore: bump DetoxSync submodule head.

7bbace4

fix(iOS): support RNCSliderComponentView slider.

86343ff

Callstack's slider view has a property called 'slider' in new arch (RCTViewComponentView), which is the actual slider. See - https://github.com/callstack/react-native-slider/blob/main/package/ios/RNCSliderComponentView.mm#L26

test: remove react-native .71 old test.

5f46e01

test(iOS): ensure wrapping element is accessible.

9f40644

test(ios): fix matcher class name.

c58cac8

fix(ios): extract slider property only if exists.

743390e

test(ios): undo skip tests due to new-arch.

57a7d38

test(ios): change element accessibility for fabric tests.

72c93fd

feat(iOS): support ToggleValueExpectation for new arch.

95388b5

fix(iOS): migrate to RCT_EXPORT_METHOD.

3d145bb

test(ios): skip bridge stress test.

87c9ea2

test: add @New-arch and @legacy test markers (for specifying test-env).

44f3095

test: skip tests on new arch.

f735c2b

JSI timers are not being synced on new arch (iOS) since we cannot swizzle them.

test(ios): fix overlay messages layout

ec91497

test(ios): fix test expectation

b3db439

test(ios): disable failing check on new-arch.

915275c

asafkorem force-pushed the feat/bridgeless-mode branch from fea3349 to 915275c Compare February 1, 2025 16:42

asafkorem added 11 commits February 2, 2025 08:51

test(ios): update web-view image snapshot.

abccfe5

test(ios): apply changes due to new-arch class-name changes.

316ef6a

fix(ios): JS crash handling on new-arch.

b6ae4cc

test(ios): crash handling.

743c2bb

chore(.github): update upload-artifact on actions.

2d498e7

test(ios): mark flaky test.

2e1cdb7

chore: revent pipeline_common changes (comments).

a40f974

Merge branch 'master' into feat/bridgeless-mode

3718329

Merge remote-tracking branch 'origin/master' into feat/bridgeless-mode

525a6bb

test: replace jestExpect with expectToThrow

193ae92

fix(ios): do not dispatch-async on mainthread if already running on.

43f71e4

asafkorem marked this pull request as ready for review February 15, 2025 15:52

asafkorem requested review from d4vidi and noomorph as code owners February 15, 2025 15:52

test(ios new arch): update snapshots.

ec530a8

asafkorem force-pushed the feat/bridgeless-mode branch from 98fb331 to ec530a8 Compare February 15, 2025 17:17

asafkorem merged commit b872570 into master Feb 16, 2025
2 of 3 checks passed

asafkorem deleted the feat/bridgeless-mode branch February 16, 2025 11:05

asafkorem mentioned this pull request Feb 16, 2025

Fix Detox test app's picker & date-picker screens on New Arch (iOS) #4679

Closed

d4vidi reviewed Feb 16, 2025

View reviewed changes

detox/test/e2e/09.stress-timeouts.test.js Show resolved Hide resolved

d4vidi reviewed Feb 16, 2025

View reviewed changes

detox/test/e2e/12.animations.test.js Show resolved Hide resolved

d4vidi reviewed Feb 16, 2025

View reviewed changes

detox/test/e2e/17.datePicker.test.js Show resolved Hide resolved

d4vidi self-assigned this Feb 16, 2025

d4vidi reviewed Feb 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iOS): support bridgeless mode. #4681

feat(iOS): support bridgeless mode. #4681

asafkorem commented Jan 8, 2025

d4vidi Feb 17, 2025

asafkorem Feb 18, 2025 •

edited

Loading

asafkorem Feb 18, 2025

d4vidi Feb 17, 2025

asafkorem Feb 18, 2025 •

edited

Loading

asafkorem Feb 18, 2025 •

edited

Loading

asafkorem Feb 18, 2025

d4vidi Feb 17, 2025

asafkorem Feb 18, 2025

d4vidi Feb 17, 2025 •

edited

Loading

asafkorem Feb 18, 2025

d4vidi Feb 17, 2025

		@@ -1,4 +1,4 @@
		describe.skipIfNewArchOnIOS(":ios: Picker", () => {
		describe(":ios: Picker", () => {

feat(iOS): support bridgeless mode. #4681

feat(iOS): support bridgeless mode. #4681

Conversation

asafkorem commented Jan 8, 2025

Choose a reason for hiding this comment

asafkorem Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asafkorem Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

asafkorem Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d4vidi Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asafkorem Feb 18, 2025 •

edited

Loading

asafkorem Feb 18, 2025 •

edited

Loading

asafkorem Feb 18, 2025 •

edited

Loading

d4vidi Feb 17, 2025 •

edited

Loading