-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade Vite and update tests #13011
Conversation
|
98d86a1
to
ec13663
Compare
CodSpeed Performance ReportMerging #13011 will not alter performanceComparing Summary
|
@@ -74,7 +74,6 @@ describe('endpoints', () => { | |||
await done; | |||
const headers = res.getHeaders(); | |||
assert.deepEqual(headers, { | |||
'access-control-allow-origin': '*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascorbic It seems that this merge breaks my usecase. I have Astro running as Is there any way to omit the hostname check? |
@Antonytm this is a change in Vite to fix a vulnerability, so not something we control directly. Take a look at the disclosure for some of the options you can use |
Changes
Upgrades Vite to fix GHSA-vg6x-rcgg-rjx6
This is a breaking change and lots of tests were failing. This PR contains the fix, which is to ensure the host header is set.
Testing
Updates tests
Docs