Add warnings if multiple JSX renderers are used

[louisescher]

Changes

• Adds warnings to all common JSX renderer integrations if multiple known JSX renderer integrations are used at the same time. This is meant to combat the common mistake of not setting the include or exclude options when using multiple UI frameworks together.

Testing

As this is just a warning printed to console, no tests have been added.

Docs

As this is just a warning printed to console, no docs have been added.

[changeset-bot]

🦋 Changeset detected

Latest commit: cfade55

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ematipico]

Have you considered having this logic in core? The integrations shouldn't be aware of each other, instead the core needs to know

[florian-lefebvre]

I think the issue is core doesn't have access to the integrations options so it can't check include/exclude

[louisescher]

@florian-lefebvre is correct. Core would've been the better solution but it can't see what options are passed

[ematipico]

I don't see any issue at all. We could expose a utility from astro/config called getKnownJsxRenderers which does what this PR implemented.

[louisescher]

@ematipico Is that just for the known renderers so that the integration can throw the warning? I'd be happy to implement it there

[ematipico]

Yeah just for the known JSX renderers, it seems

[bluwy]

I'm personally happy with this current approach to keep things simple. I don't know if we need to expose a new API here to avoid the hardcoding. The downside with that is that integrations will require a newer version of Astro, so if the end-user only upgrades the integration and not Astro, it'll fail to import in runtime, which is a breaking change.

[sarah11918]

Left a comment in the docs PR !