Add server island route to the front of the route list (#12263)

Fryuni · web-flow · commit e9e8080a8139 · 2024-10-21T12:13:52.000-04:00
* Add server island route to the front of the route list

* Add changeset
diff --git a/.changeset/honest-dots-jump.md b/.changeset/honest-dots-jump.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes conflict between server islands and on-demand dynamic routes in the form of `/[...rest]` or `/[paramA]/[paramB]`.
diff --git a/packages/astro/e2e/fixtures/server-islands/src/pages/[conflicting]/[dynamicRoute].astro b/packages/astro/e2e/fixtures/server-islands/src/pages/[conflicting]/[dynamicRoute].astro
@@ -0,0 +1,14 @@
+---
+export const prerender = false;
+---
+
+<html>
+	<head>
+		<title>Conflicting route</title>
+	</head>
+	<body>
+		This route would conflict with the route generated for server islands.
+		<br />
+		This file is here so the tests break if that happens.
+	</body>
+</html>
diff --git a/packages/astro/src/core/server-islands/endpoint.ts b/packages/astro/src/core/server-islands/endpoint.ts
@@ -44,7 +44,7 @@ export function ensureServerIslandRoute(config: ConfigFields, routeManifest: Man
 		return;
 	}
 
-	routeManifest.routes.push(getServerIslandRouteData(config));
+	routeManifest.routes.unshift(getServerIslandRouteData(config));
 }
 
 type RenderOptions = {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export function ensureServerIslandRoute(config: ConfigFields, routeManifest: Man`
`44`	`44`	`return;`
`45`	`45`	`}`
`46`	`46`
`47`		`- routeManifest.routes.push(getServerIslandRouteData(config));`
	`47`	`+ routeManifest.routes.unshift(getServerIslandRouteData(config));`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`type RenderOptions = {`