Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commons-fileupload to load commons-io as a transitive dependency #2691

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

leeturner
Copy link
Contributor

This PR is a fix for #2688 where commons-fileupload was not loading commons-io as a transitive dependency. Now we have removed our dependency on commons-io we can now allow commons-fileupload to pull it in as a transitive dependency

References

#2688

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@leeturner leeturner requested a review from a team as a code owner April 22, 2024 16:48
@leeturner leeturner merged commit 2a4e236 into master Apr 22, 2024
9 checks passed
@leeturner leeturner deleted the allow-commons-io-transitive-dep branch April 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants