Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2665 - WireMock.stubFor throws descriptive exception message on 404 error code from non-WireMock server instead of unclear JsonException #2666

Conversation

vasiliy-sarzhynskyi
Copy link
Contributor

@vasiliy-sarzhynskyi vasiliy-sarzhynskyi commented Apr 2, 2024

WireMock.stubFor(..) should throw descriptive exception message on 404 error code from non-WireMock server instead of an unclear JsonException

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

…essage on 404 error code from non-WireMock server instead of unclear JsonException
@vasiliy-sarzhynskyi vasiliy-sarzhynskyi requested a review from a team as a code owner April 2, 2024 18:09
@dieppa dieppa self-assigned this Apr 9, 2024
Copy link
Contributor

@dieppa dieppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vasiliy-sarzhynskyi , your change looks good and it seems that provides value without adding a breaking change; it doesn't change the error structure, just the error message, which is ok.

However, this is a minor change I would like to have in the tests before merging it.

Thanks in advance!

@dieppa dieppa merged commit 5cd176b into wiremock:master Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants