Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publications by excluding testFixturesApi components #2661

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Mar 30, 2024

Fix publications by excluding testFixturesApi components. Those cause an invalid POM file being generated:

[WARNING] The POM for org.wiremock:wiremock:jar:3.5.1 is invalid, transitive dependencies (if any) will not be available: 3 problems were encountered while building the effective model for org.wiremock:wiremock:3.5.1

Verified locally with ./gradlew localRelease

References

Closes #2660

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta requested a review from a team as a code owner March 30, 2024 19:57
@@ -362,6 +362,9 @@ publishing {
}
}

components.java.withVariantsFromConfiguration(configurations.testFixturesApiElements) { skip() }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to Gradle documentation here:

If you publish your library and use test fixtures, but do not want to publish the fixtures, you can deactivate publishing of the test fixtures variants as shown below. - https://docs.gradle.org/current/userguide/java_testing.html

@tomakehurst tomakehurst merged commit 04e3b51 into wiremock:master Mar 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating 3.4.2 -> 3.5.1 broken
2 participants