Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpsBrowserProxyAcceptanceTest #2314

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Aug 13, 2023

Fix HttpsBrowserProxyAcceptanceTest

Fix \wiremock\src\test\java\com\github\tomakehurst\wiremock\HttpsBrowserProxyAcceptanceTest.java:143: warning: [removal] getProxies() in ProxyConfiguration has been deprecated and marked for removal
proxyConfig.getProxies().add(httpProxy);

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Sorry, something went wrong.

@pks-1981 pks-1981 requested a review from a team as a code owner August 13, 2023 09:08
@pks-1981
Copy link
Contributor Author

@tomakehurst
or just removing that?
Because @disabled("Jetty doesn't yet support proxying via HTTP2")

@pks-1981 pks-1981 changed the title HttpsBrowserProxyAcceptanceTest Fix HttpsBrowserProxyAcceptanceTest Aug 13, 2023
@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 15, 2023
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleg-nenashev oleg-nenashev merged commit 3712b59 into wiremock:master Aug 15, 2023
@pks-1981 pks-1981 deleted the proxy branch August 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants