Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default ObjectMapper with JavaTimeModule #2130

Merged
merged 2 commits into from
May 31, 2023

Conversation

mark-henry
Copy link
Contributor

@mark-henry mark-henry commented Apr 11, 2023

Fixes #1127

@mark-henry
Copy link
Contributor Author

I chose to put tests in ParametersTest.java. I hope that was the right choice.

The context is that I have never submitted a PR to an open source project so lmk if any feedback whee ty

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new library will be shaded by the existing relocate configuration

@mark-henry
Copy link
Contributor Author

mark-henry commented Apr 14, 2023

Exciting! If merged, what version would this be part of, and approximately when would that version be released?

@mark-henry
Copy link
Contributor Author

@tomakehurst bump :)

@oleg-nenashev
Copy link
Member

I will review open pull requests with @tomakehurst when we has sometime (or allows me to merge ready-to-go stuff )

@oleg-nenashev oleg-nenashev added the needs-tom Tom's Train Project :) label May 6, 2023
@tomakehurst tomakehurst merged commit bb64a7b into wiremock:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-tom Tom's Train Project :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to register JavaTimeModule on latest version of Wiremock
3 participants