-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disabling of browser proxy pass-through #2087
Support disabling of browser proxy pass-through #2087
Conversation
Looking good so far. Please can you add an acceptance test that demonstrates this?
|
@tomakehurst I have added acceptance tests. |
Again, looking great. One thing I meant to mention (apologies for not remembering before) - please can you also add a flag to The value from this can be used to set the default in the global settings I think. |
@tomakehurst yea yea sure, no worries. I will do the same and get back. |
@tomakehurst I have added flag proxy pass through as option via the CLI and on programmatic startup. |
src/main/java/com/github/tomakehurst/wiremock/global/GlobalSettings.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/tomakehurst/wiremock/global/GlobalSettings.java
Outdated
Show resolved
Hide resolved
…ock.global.GlobalSettings.Builder#proxyPassThrough variable type to primitive
@tomakehurst I have incorporated all comments. Could you please check this PR. |
src/main/java/com/github/tomakehurst/wiremock/core/WireMockConfiguration.java
Outdated
Show resolved
Hide resolved
@tomakehurst I have incorporated review comment changes. You can review and let me know. |
OK, I think this looks good so I'll merge it assuming the build is OK. One last request - please could you open a PR against the docs repo to add the relevant documentation for this? |
Sure @tomakehurst I ll add another PR for adding relevant documentation. |
resolves => #1909
Added flag in global settings to control proxy pass-through. By default, it will be true and allows the request to go to the original URL. If flag will be false, it will return nearest matching stubbed request.
@tomakehurst you can review this PR.