Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling of browser proxy pass-through #2087

Merged
merged 10 commits into from
Mar 13, 2023
Merged

Support disabling of browser proxy pass-through #2087

merged 10 commits into from
Mar 13, 2023

Conversation

kapishmalik
Copy link
Contributor

resolves => #1909

Added flag in global settings to control proxy pass-through. By default, it will be true and allows the request to go to the original URL. If flag will be false, it will return nearest matching stubbed request.

@tomakehurst you can review this PR.

@tomakehurst
Copy link
Member

Looking good so far. Please can you add an acceptance test that demonstrates this?

BrowserProxyAcceptanceTest is probably the right place for this.

@kapishmalik
Copy link
Contributor Author

@tomakehurst I have added acceptance tests.

@tomakehurst
Copy link
Member

Again, looking great.

One thing I meant to mention (apologies for not remembering before) - please can you also add a flag to Options for this, so that it's also possible to set it via the CLI and on programmatic startup?

The value from this can be used to set the default in the global settings I think.

@kapishmalik
Copy link
Contributor Author

@tomakehurst yea yea sure, no worries. I will do the same and get back.

@kapishmalik
Copy link
Contributor Author

kapishmalik commented Feb 27, 2023

@tomakehurst I have added flag proxy pass through as option via the CLI and on programmatic startup.

…ock.global.GlobalSettings.Builder#proxyPassThrough variable type to primitive
@kapishmalik
Copy link
Contributor Author

@tomakehurst I have incorporated all comments. Could you please check this PR.

@kapishmalik
Copy link
Contributor Author

@tomakehurst I have incorporated review comment changes. You can review and let me know.

@tomakehurst
Copy link
Member

OK, I think this looks good so I'll merge it assuming the build is OK.

One last request - please could you open a PR against the docs repo to add the relevant documentation for this?
I think the standalone (for the CLI bits) and the proxying pages are the ones to aim for.

@kapishmalik
Copy link
Contributor Author

Sure @tomakehurst I ll add another PR for adding relevant documentation.

@tomakehurst tomakehurst merged commit 6bb45eb into wiremock:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants