Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Lazy Option in transport #2317

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Added Lazy Option in transport #2317

merged 7 commits into from
Jul 10, 2023

Conversation

Pulkit0729
Copy link
Contributor

This change tries to address the issue #1494.

-Added lazy option in file transport

  • Added test case for file rotation format
  • Added test case for lazy option

This was referenced Jun 27, 2023
Closed
Closed
@DABH
Copy link
Contributor

DABH commented Jun 28, 2023

@Pulkit0729 Can you work on getting CI to pass first? Looks like first issue is there are linter problems…

@Pulkit0729
Copy link
Contributor Author

Pulkit0729 commented Jun 28, 2023 •
edited

Hey @DABH , Completed the CI. You can have a look now

DABH
DABH approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good and well-tested to me. I am ok with approving this with the minor formatting suggestions taken into account. Thanks for your contribution!

test/unit/winston/transports/01-file-maxsize.test.js Outdated Show resolved Hide resolved
test/unit/winston/transports/01-file-maxsize.test.js Outdated Show resolved Hide resolved
Pulkit0729 and others added 2 commits July 10, 2023 11:26
@Pulkit0729 @DABH
Update test/unit/winston/transports/01-file-maxsize.test.js
6ab1c03 
Co-authored-by: David Hyde <DABH@users.noreply.github.com>
@Pulkit0729 @DABH
Update test/unit/winston/transports/01-file-maxsize.test.js
b4f7af0 
Co-authored-by: David Hyde <DABH@users.noreply.github.com>
@DABH DABH merged commit f7e7f2f into winstonjs:master Jul 10, 2023
4 checks passed
@Nol-go Nol-go mentioned this pull request Jul 19, 2023
Closed
This was referenced May 19, 2024
Open
Open
@paaschdigital paaschdigital mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
Open
@cvs-ops cvs-ops mentioned this pull request May 24, 2024
Open
@rish2497 rish2497 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@rish2497 rish2497 mentioned this pull request May 25, 2024
Open
@nc-minh nc-minh mentioned this pull request May 25, 2024
Open
@cvs-ops cvs-ops mentioned this pull request May 25, 2024
Open
@slatersnyk slatersnyk mentioned this pull request May 25, 2024
Open
@fanibahar fanibahar mentioned this pull request May 25, 2024
Open
@paladinmansouri paladinmansouri mentioned this pull request May 26, 2024
Open
@marcos-test-dev marcos-test-dev mentioned this pull request May 26, 2024
Open
@drwho725 drwho725 mentioned this pull request May 26, 2024
Closed
This was referenced May 26, 2024
Open
Open
@AnushaSalian AnushaSalian mentioned this pull request May 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 1, 2024
Open
@TheTechSurgeon TheTechSurgeon mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pulkit0729 @DABH