Update supported Node versions and run npm audit fix #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has been having some issues on community-contributed PRs, and it seems like at least some of the cause is due to old Node versions we're using (the dependencies of winston have made changes that break compatibility with old Node versions it seems, particularly things like
tsc/Typescript). I think it's appropriate to continue a policy of having the Winston ecosystem only support supported versions of Node.Edit: Given the current bandwidth of maintainers I'm also going to going to lower the function coverage threshold to 70% from 73.21%; hoping we can bump this back up if we can find a volunteer to add coverage...