Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ruby versions on test job #39

Merged

Conversation

m-nakamura145
Copy link
Contributor

This Pull Request updates the CI configuration to always use the latest stable version of Ruby.

@iliabylich
Copy link
Collaborator

May I ask you to wrap them with parentheses? 3.0.0 is a string in YAML and so it precisely defines the version, 3.0 becomes a float that gets "rounded" to just 3 which I assume is the latest 3.x.y version (you can check it yourself by looking at the output of 3.0 job, it's been executed with 3.3.1)

@mbj
Copy link
Contributor

mbj commented May 21, 2024

May I ask you to wrap them with parentheses?

I wish github would allow re-usable workflows like ruby/setup-ruby to specify type expectations in their parameters. This would avoid these kinds of footguns.

Verified

This commit was signed with the committer’s verified signature.
m-nakamura145 Masato Nakamura
@m-nakamura145 m-nakamura145 force-pushed the use-latest-ruby-versions branch from a07a46e to 6c8622a Compare May 22, 2024 08:17
@m-nakamura145
Copy link
Contributor Author

@iliabylich Thank you! Fixed! 6c8622a

@iliabylich iliabylich merged commit d1d0c84 into whitequark:master May 22, 2024
10 checks passed
@iliabylich
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants