Store client ID in Redix.PubSub
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethito
force-pushed
the
feature/pubsub-client-id
branch
from
8e0cee6
to
3a54184
Compare
whatyouhide
changed the title
Redix.PubSub
Pull Request Test Coverage Report for Build 3a541844408585b940b2cfd454b716483cebd7c9-PR-261Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't exactly sure what direction to take this, issuing "sync" commands within the pubsub is awkward, let me know if you'd prefer a different approach.
One thing to note though, for the redirecting invalidations from normal connections to the pubsub, the client id should be available as early as possible.
closes #260