Skip to content

Commit 8b0726c

Browse files
EdouardBougontmm
andauthoredDec 11, 2024··
fix: update metamask sdk and fix metadata handling for empty URL (#4456)
* fix: update metamask sdk and fix metadata handling for empty URL * chore: tweaks --------- Co-authored-by: Tom Meagher <tom@meagher.co>
1 parent 96f6849 commit 8b0726c

File tree

4 files changed

+72
-63
lines changed

4 files changed

+72
-63
lines changed
 

‎.changeset/warm-melons-joke.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@wagmi/connectors": patch
3+
---
4+
5+
Bumped MetaMask SDK and fixed internal metadata handling.

‎packages/connectors/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
},
4747
"dependencies": {
4848
"@coinbase/wallet-sdk": "4.2.3",
49-
"@metamask/sdk": "0.31.1",
49+
"@metamask/sdk": "0.31.2",
5050
"@safe-global/safe-apps-provider": "0.18.4",
5151
"@safe-global/safe-apps-sdk": "9.1.0",
5252
"@walletconnect/ethereum-provider": "2.17.0",

‎packages/connectors/src/metaMask.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -260,11 +260,15 @@ export function metaMask(parameters: MetaMaskParameters = {}) {
260260
// Workaround cast since MetaMask SDK does not support `'exactOptionalPropertyTypes'`
261261
...(parameters as RemoveUndefined<typeof parameters>),
262262
readonlyRPCMap,
263-
dappMetadata:
264-
parameters.dappMetadata ??
265-
(typeof window !== 'undefined'
266-
? { url: window.location.origin }
267-
: { name: 'wagmi', url: 'https://wagmi.sh' }),
263+
dappMetadata: {
264+
...parameters.dappMetadata,
265+
name: parameters.dappMetadata?.name ?? 'wagmi',
266+
url:
267+
parameters.dappMetadata?.url ??
268+
(typeof window !== 'undefined'
269+
? window.location.origin
270+
: 'https://wagmi.sh'),
271+
},
268272
useDeeplink: parameters.useDeeplink ?? true,
269273
})
270274
const result = await sdk.init()

‎pnpm-lock.yaml

+57-57
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.