Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing api.rst; call sphinx-apidoc in RTD pre-build #121

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

cmarqu
Copy link
Contributor

@cmarqu cmarqu commented Jan 3, 2024

Before merging, please enable PR builds as described in https://docs.readthedocs.io/en/stable/guides/pull-requests.html,
then let me try another push.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2066ebd) 98.24% compared to head (e8054cc) 98.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files           8        8           
  Lines        1428     1428           
=======================================
  Hits         1403     1403           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmarqu cmarqu marked this pull request as draft January 3, 2024 19:18
@weiwei
Copy link
Owner

weiwei commented Jan 4, 2024

Hi @cmarqu PR builds is enabled. You can continue now.

@cmarqu
Copy link
Contributor Author

cmarqu commented Jan 4, 2024

Hmm, I don't see an RTD build yet, maybe the PR must be out of Draft state, let's try that...

@cmarqu cmarqu marked this pull request as ready for review January 4, 2024 16:09
@cmarqu
Copy link
Contributor Author

cmarqu commented Jan 4, 2024

Doesn't work...
Do you see an RTD webhook configured under https://github.com/weiwei/junitparser/settings/hooks ?
https://docs.readthedocs.io/en/stable/guides/pull-requests.html#troubleshooting also has some tips.

@weiwei
Copy link
Owner

weiwei commented Jan 5, 2024

Yes @cmarqu the config should be correct. I'll merge this first to see if it gets triggered.

@weiwei weiwei merged commit 8ad4d6c into weiwei:master Jan 5, 2024
8 checks passed
@weiwei
Copy link
Owner

weiwei commented Jan 5, 2024

OK webhooks by default are triggered by pushes not PRs. It did run after I merge, but failed on the newly added command: https://readthedocs.org/projects/junitparser/builds/23025833/

@weiwei
Copy link
Owner

weiwei commented Jan 5, 2024

@cmarqu I think I've properly enabled webhook for PR now. You can test it out.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants