Skip to content

Commit 80e2002

Browse files
committedJul 7, 2018
[major] Drop support for the memLevel and level options
1 parent 92d0a2e commit 80e2002

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed
 

‎lib/permessage-deflate.js

+1-9
Original file line numberDiff line numberDiff line change
@@ -413,15 +413,7 @@ class PerMessageDeflate {
413413
: this.params[key];
414414

415415
this._deflate = zlib.createDeflateRaw(
416-
Object.assign(
417-
// TODO deprecate memLevel/level and recommend zlibDeflateOptions instead
418-
{
419-
memLevel: this._options.memLevel,
420-
level: this._options.level
421-
},
422-
this._options.zlibDeflateOptions,
423-
{ windowBits }
424-
)
416+
Object.assign({}, this._options.zlibDeflateOptions, { windowBits })
425417
);
426418

427419
this._deflate[kTotalLength] = 0;

‎test/permessage-deflate.test.js

+10-3
Original file line numberDiff line numberDiff line change
@@ -349,8 +349,14 @@ describe('PerMessageDeflate', function () {
349349
});
350350

351351
it('honors the `level` option', function (done) {
352-
const lev0 = new PerMessageDeflate({ threshold: 0, level: 0 });
353-
const lev9 = new PerMessageDeflate({ threshold: 0, level: 9 });
352+
const lev0 = new PerMessageDeflate({
353+
threshold: 0,
354+
zlibDeflateOptions: { level: 0 }
355+
});
356+
const lev9 = new PerMessageDeflate({
357+
threshold: 0,
358+
zlibDeflateOptions: { level: 9 }
359+
});
354360
const extensionStr = (
355361
'permessage-deflate; server_no_context_takeover; ' +
356362
'client_no_context_takeover; server_max_window_bits=10; ' +
@@ -409,7 +415,8 @@ describe('PerMessageDeflate', function () {
409415
}
410416
});
411417

412-
// Note no context takeover so we can get a hold of the raw streams after we do the dance
418+
// Note no context takeover so we can get a hold of the raw streams after
419+
// we do the dance.
413420
const extensionStr = (
414421
'permessage-deflate; server_max_window_bits=10; ' +
415422
'client_max_window_bits=11'

0 commit comments

Comments
 (0)
Please sign in to comment.