on_reconnect callback #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changing default behavior)
Closed
|
This looks reasonable to me. Adding the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 971 (#971) discusses an ambiguity in our callback system between the connection opening for the first time and subsequent automatic reconnects.
To address this, this PR adds support for an on_reconnect callback. The on_reconnect callback (instead of the on_open callback) is called from setSock() on a reconnect. If no on_reconnect callback is provided, the previous behavior (of calling on_open on a reconnect) is preserved.
Ticket 974 (#974) involves the somewhat related case of WebSocketApp reuse after the server intentionally disconnects. @GooVincent identified the solution, setting has_done_teardown to False.