Fix type annotations in the str | bytes #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st
changed the title
|
Thanks for the PR. mypy will be added to CI after more mypy warnings are resolved. |
Thanks. If will face any other issues will make a follow-up fix |
engn33r
added a commit
that referenced
this pull request
Sep 1, 2023
|
Yes. It's modern syntax. If you need an old syntax then create a branch for supporting old version of Python. Or you want to have a single version version that covers old and new versions? |
|
There is only a single version of the library to support all versions of python that are not EOL. The supported versions right now are 3.8+, listed in setup.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've faced an issue with Mypy that it complains about passing string to the ws.send() method. And found that you use bytes or str instead of the Python built-in pipe to be
str | bytes.Checked with Mypy and it works fine now.