Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSLKEYLOGFILE #943

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add support for SSLKEYLOGFILE #943

merged 2 commits into from
Aug 15, 2023

Conversation

Nicoretti
Copy link
Contributor

Hi @ all,

Thanks for maintaining and providing this library, appreciate it! 馃憤

Recently I have been debugging some protocol on top of websockets. The client I have been debugging
was using this library for it's websocket communication. This is why I stumbled upon the fact, that
the SSLKEYLOGFILE will be not supported in all cases when using this library.
I am aware that one always can pass a completely custom SSLContext, but I am not 100% sure if that should
be required here. Happy to get some feedback on this from the maintainers.

Summary

Python >= 3.8 supports SSLKEYLOGFILE for debugging, see here.
Which is a very helpful feature for debugging SSL/TLS connections without disabling it.

What is this good for?

The SSLKEYLOGFILE can be used to dump TLS session keys to a file which enables the user to decrypt the TLS traffic. This has the "advantage" that an actual TLS secured connection can be debugged, rather than a connection
where TLS is disabled. In some scenarios, connecting without TLS may not even be possible.

See also

I hope the provided information is sufficient.

best
Nico

@engn33r engn33r merged commit bf99123 into websocket-client:master Aug 15, 2023
2 of 7 checks passed
@engn33r
Copy link
Collaborator

engn33r commented Aug 15, 2023

Thanks for the helpful PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants