Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ all,
Thanks for maintaining and providing this library, appreciate it! 馃憤
Recently I have been debugging some protocol on top of
websockets
. The client I have been debuggingwas using this library for it's
websocket
communication. This is why I stumbled upon the fact, thatthe
SSLKEYLOGFILE
will be not supported in all cases when using this library.I am aware that one always can pass a completely custom SSLContext, but I am not 100% sure if that should
be required here. Happy to get some feedback on this from the maintainers.
Summary
Python >= 3.8
supportsSSLKEYLOGFILE
for debugging, see here.Which is a very helpful feature for debugging SSL/TLS connections without disabling it.
What is this good for?
The
SSLKEYLOGFILE
can be used to dumpTLS
session keys to a file which enables the user to decrypt theTLS
traffic. This has the "advantage" that an actualTLS
secured connection can be debugged, rather than a connectionwhere
TLS
is disabled. In some scenarios, connecting without TLS may not even be possible.See also
I hope the provided information is sufficient.
best
Nico