Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https_proxy environment variable for secure connections #929

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

j-a-n
Copy link
Contributor

@j-a-n j-a-n commented Jul 10, 2023

Use https_proxy environment variable for secure connections and do not fallback to http_proxy.
Fixes #927

@engn33r
Copy link
Collaborator

engn33r commented Jul 29, 2023

I agree with the update. Although the user is expected to set is_secure to true when https_proxy is set, the updated code makes it more clear and foolproof that is_secure controls whether http_proxy or https_proxy is chosen. This avoids the case of falling back to http_proxy if https_proxy is not set when the user specifically sets is_secure to true.

Thanks for adding test coverage 👍

@engn33r engn33r merged commit 3fa4cfc into websocket-client:master Jul 29, 2023
3 of 7 checks passed
@j-a-n
Copy link
Contributor Author

j-a-n commented Aug 4, 2023

Thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variable HTTP_PROXY is used for HTTPS connections
2 participants