Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: If a user is not a part of any orgs, login will fail due to exception. #2491

Closed
ikreymer opened this issue Mar 18, 2025 · 1 comment
Closed

[Bug]: If a user is not a part of any orgs, login will fail due to exception. #2491

ikreymer opened this issue Mar 18, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ikreymer
Copy link
Member

Browsertrix Version

v1.14.4

What did you expect to happen? What happened instead?

If a user somehow is not part of any orgs, logging in will fail on the frontend, due to an uncaught exception, resulting in a 'something went wrong' error.

We should remove users that aren't part of any orgs, but if such users exist, should still not fail login.

Reproduction instructions

  1. Attempt to login as user who is not part of any orgs
  2. Observe "Something went wrong" error on frontend, although backend returns 200.

Screenshots / Video

No response

Environment

No response

Additional details

No response
@ikreymer ikreymer added the bug Something isn't working label Mar 18, 2025
ikreymer added a commit that referenced this issue Mar 18, 2025
@ikreymer
fixes #2491
Loading
Loading status checks…
9df31e3 
if logged in user is not part of any orgs, still allow logging in, instead of throwing an exception
due to accessing non-existent org
ikreymer added a commit that referenced this issue Mar 19, 2025
@ikreymer @SuaYoo
login: don't set default slug if user not part of any orgs #2491 (#2492)
Loading
Loading status checks…
c9c32d8 
if logged in user is not part of any orgs, still allow logging in,
instead of throwing an exception due to accessing non-existent org

---------

Co-authored-by: sua yoo <sua@suayoo.com>
@github-project-automation github-project-automation bot moved this from Triage to Done! in Webrecorder Projects Mar 24, 2025
@ikreymer
Copy link
Member Author

Fixed in 1.14.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikreymer