Workspace graph not computed correctly

[TimPetricola]

Prerequisites

• I'm using the latest version
• I've read the relevant documentation
• I've searched for existing issues
• I've checked the list of known issues
• I've read the issue reproduction guide

Reproduction url

https://stackblitz.com/edit/github-qsxgp9wd?file=debug.txt

Reproduction access

• I've made sure the reproduction is publicly accessible

Description of the issue

When running knip for a single workspace, it's supposed to analyze both ancestors and dependents of the workspace. However it seems to currently only handle ancestors properly.

To reproduce:

1. open the default monorepo reproduction StackBlitz (or here)
2. run yarn knip -W packages/client --debug > debug.txt
3. search for "Included workspaces" in debug.txt

I would expect to find:

• @knip/templates-monorepo (the ancestor) ✅
• @monorepo/client (the actual package) ✅
• @monorepo/shared (the dependent) ❌

But the last one is missing.

As a result, analyzing a single package is broken as it reports false negatives used in dependents.

I'm not completely sure, but I think the bug comes form this line as:

• wsPackages contains the package paths
• but name contains the package name

So this is always evaluates to false

[webpro]

🚀 This issue has been resolved in v5.44.3. See Release 5.44.3 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

[webpro]

Thanks for the report, Tim! Turns out that line you point out was returning itself 😱 No idea how this could creep in there, but I've added some coverage so this shouldn't happen again.

[TimPetricola]

@webpro wooh thanks for being so reactive! I confirm the fix works fine in latest version 🙏

[webpro]

🫡