Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 Production Mode considers dependencies since v5.42.0 #914

Closed
4 tasks done
y-yagi opened this issue Jan 17, 2025 · 3 comments
Closed
4 tasks done

🔄 Production Mode considers dependencies since v5.42.0 #914

y-yagi opened this issue Jan 17, 2025 · 3 comments
Labels
regression Something is no longer working

Comments

@y-yagi
Copy link

y-yagi commented Jan 17, 2025

Prerequisites

Reproduction url

https://github.com/y-yagi/knip-issue-unlisted-binaries

Reproduction access

  • I've made sure the reproduction is publicly accessible

Good version

5.42.0

Bad version

5.41.1

Description of the regression

We run the following steps on CI. And, we have turbo as devDependencies.

steps:
  - name: Run knip
    run: pnpm knip --production

  - name: Build
    run: pnpm turbo run build 

Since v5.42.0, Knip reports turbo as Unlisted binaries.

Unlisted binaries (2)
turbo  .github/workflows/ci.yml 

I understand the intention, but I could not find any information about these changes in the release notes. So let me ask this change if this is intended or not.

@y-yagi y-yagi added the regression Something is no longer working label Jan 17, 2025
@y-yagi y-yagi changed the title 🔄 Production Mode considers dependencies Knip since v5.42.0 🔄 Production Mode considers dependencies since v5.42.0 Jan 17, 2025
@webpro webpro closed this as completed in c510a35 Jan 17, 2025
@webpro
Copy link
Member

webpro commented Jan 17, 2025

Thanks for the report, @y-yagi!

I think this was introduced in https://github.com/webpro-nl/knip/releases/tag/5.42.1, started with the 1731ee5 refactor.

There have been some improvements in this area, hopefully things got better after my fixes.

@webpro
Copy link
Member

webpro commented Jan 17, 2025

🚀 This issue has been resolved in v5.42.2. See Release 5.42.2 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@y-yagi
Copy link
Author

y-yagi commented Jan 17, 2025

Thanks for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something is no longer working
Projects
None yet
Development

No branches or pull requests

2 participants