Fix dynamically added config files for disabled plugins (resolve #947)

Author: webpro

packages/knip/fixtures/plugin-disable/knip.json

@@ -0,0 +1,5 @@
+{
+  "workspaces": {
+    "ws": {}
+  }
+}

packages/knip/fixtures/plugin-disable/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "@fixtures/plugin-disable",
+  "workspaces": ["ws"],
+  "scripts": {
+    "test": "vitest -c vite.config.ts"
+  }
+}

packages/knip/fixtures/plugin-disable/vite.config.ts

@@ -0,0 +1,7 @@
+const getValues = () => {
+  throw new Error("This plugin should've been ignored");
+};
+
+export default {
+  someValue: getValues(),
+};

packages/knip/fixtures/plugin-disable/ws/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@fixtures/plugin-disable-workspace",
+  "scripts": {
+    "playwright-test": "playwright test --config playwright.config.ts"
+  }
+}

packages/knip/fixtures/plugin-disable/ws/playwright.config.ts

@@ -0,0 +1,7 @@
+const getValues = () => {
+  throw new Error("This plugin should've been ignored");
+};
+
+export default {
+  someValue: getValues(),
+};

packages/knip/src/WorkspaceWorker.ts

@@ -376,7 +376,8 @@ export class WorkspaceWorker {
     do {
       for (const [pluginName, dependencies] of configFiles.entries()) {
         configFiles.delete(pluginName);
-        await runPlugin(pluginName, Array.from(dependencies));
+        if (this.enabledPlugins.includes(pluginName)) await runPlugin(pluginName, Array.from(dependencies));
+        else for (const id of dependencies) addInput(toEntry(id));
       }
     } while (remainingPlugins.size > 0 && configFiles.size > 0);
 

packages/knip/test/plugin-disable.test.ts

@@ -0,0 +1,22 @@
+import { test } from 'bun:test';
+import assert from 'node:assert/strict';
+import { main } from '../src/index.js';
+import { resolve } from '../src/util/path.js';
+import baseArguments from './helpers/baseArguments.js';
+import baseCounters from './helpers/baseCounters.js';
+
+const cwd = resolve('fixtures/plugin-disable');
+
+test('Disable plugin from dynamically added config file', async () => {
+  const { counters } = await main({
+    ...baseArguments,
+    cwd,
+  });
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    binaries: 2,
+    total: 2,
+    processed: 2,
+  });
+});