Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(perf) optimize assign-depths #19193

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dmichon-msft
Copy link
Contributor

Roughly 5% of my team's watch-mode rebuilds is spent in the assignDepths function. This change reduces that to 3%

What kind of change does this PR introduce?
performance enhancement

Did you add tests for your changes?
Covered by existing unit tests for this function. Not a logic change.

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
Performance only, no behavior change, so nothing.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Sorry, something went wrong.

@alexander-akait alexander-akait merged commit ddc3782 into webpack:main Feb 5, 2025
59 of 63 checks passed
@alexander-akait
Copy link
Member

Thanks

@dmichon-msft dmichon-msft deleted the assign-depths branch February 6, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants