-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve FlagDependencyExportsPlugin for large JSON by depth #19058
Merged
alexander-akait
merged 3 commits into
webpack:main
from
hai-x:hai-x/perf-json-flagDepExports
Dec 19, 2024
Merged
perf: improve FlagDependencyExportsPlugin for large JSON by depth #19058
alexander-akait
merged 3 commits into
webpack:main
from
hai-x:hai-x/perf-json-flagDepExports
Dec 19, 2024
+155
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For maintainers only:
|
Loading status checks…
973f619
to
38df65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make some improvements
583fa9b
to
3de7b0d
Compare
alexander-akait
approved these changes
Dec 19, 2024
I've created an issue to document this in webpack/webpack.js.org. |
Thanks |
2 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
perf only for
development
modeFixes #18458
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Add two options to https://webpack.js.org/configuration/module/#moduleparser
for
json
parse
- Function that executes for a module source string and should return json-compatible data. Type((input: string) => any)
, for For example we can use toml parserexportsDepth
- The depth of json dependency flagged asexportInfo
. In dev mode - 1, in prod - Infinity, Typenumber