Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing built-in package when targeting node: performance #17545

Closed
sagilaufer1992 opened this issue Jul 30, 2023 · 3 comments
Closed

Missing built-in package when targeting node: performance #17545

sagilaufer1992 opened this issue Jul 30, 2023 · 3 comments

Comments

@sagilaufer1992
Copy link

Bug report

performance is missing in the list of built-in packages of node that webpack uses when targeting node.

references:

What is the current behavior?
packages that require performance, a built-in package of node, will fail to compile

If the current behavior is a bug, please provide the steps to reproduce.

compile code that uses @cdktf/hcl2json@0.17.3.
that version introduces a change - requiring performance in one of it's files. reference: https://app.renovatebot.com/package-diff?name=@cdktf%2fhcl2json&from=0.17.0&to=0.17.3

you'll see an error message stating that performance is missing, even though it's a built-in package within node.

What is the expected behavior?

the package should be compiled without any modifications to the webpack configuration

Other relevant information:
webpack version: 5.88.2
Node.js version: 16.10.0
Operating System:
Additional tools:

@webpack-bot
Copy link
Contributor

This issue had no activity for at least three months.

It's subject to automatic issue closing if there is no activity in the next 15 days.

@webpack-bot
Copy link
Contributor

Issue was closed because of inactivity.

If you think this is still a valid issue, please file a new issue with additional information.

@alexander-akait
Copy link
Member

There is no built-in performance module using node v21.6.0 (npm v10.2.4):

console.log(require('repl')._builtinLibs)
[
  'assert',             'assert/strict',       'async_hooks',
  'buffer',             'child_process',       'cluster',
  'console',            'constants',           'crypto',
  'dgram',              'diagnostics_channel', 'dns',
  'dns/promises',       'domain',              'events',
  'fs',                 'fs/promises',         'http',
  'http2',              'https',               'inspector',
  'inspector/promises', 'module',              'net',
  'os',                 'path',                'path/posix',
  'path/win32',         'perf_hooks',          'process',
  'punycode',           'querystring',         'readline',
  'readline/promises',  'repl',                'stream',
  'stream/consumers',   'stream/promises',     'stream/web',
  'string_decoder',     'sys',                 'timers',
  'timers/promises',    'tls',                 'trace_events',
  'tty',                'url',                 'util',
  'util/types',         'v8',                  'vm',
  'wasi',               'worker_threads',      'zlib'
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants